I am running 5.4.1 and i can directly edit the page for editor only roles.  how do I make it force workflow?
Hi,
Our module ModuleWorflow allow you to define which roles can create new version for existing content and which roles can approve those new versions. A role can also have the 2 permissions : submit and approve. Administrators and pages editors can bypass worflow by editing page directly.
For using Page Workflow, you have to:
In DNN 5.x, don't forget to set which modules can be added to pages by desired roles by using menu Site -Extensions.
when the module is locked for editing the  module disappears from live.  is there something wrong?
do you have a guide for this?
Have you made a draft from existing content or a translation ? Have you enabled fallback ?
Relative to modules permissions, it's core feature of DotNetNuke. Go to Admin - Extensions, then edit Module and choose which roles are allowed to deploy module on page.